CHORE: solved all deprecated, comment all unused variables and functions #1763
Conversation
|
Welcome back! @lanphan, This pull request may get 374 BBG. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1763 +/- ##
==========================================
- Coverage 24.11% 23.96% -0.16%
==========================================
Files 617 623 +6
Lines 37569 38041 +472
==========================================
+ Hits 9060 9115 +55
- Misses 27711 28129 +418
+ Partials 798 797 -1
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
pkg/bbgo/activeorderbook.go
Outdated
| // } | ||
| // } | ||
| // } | ||
| // } |
There was a problem hiding this comment.
they are all un-used functions right now
pkg/bbgo/activeorderbook.go
Outdated
| } | ||
| } | ||
| } | ||
| // func (b *ActiveOrderBook) waitClear( |
There was a problem hiding this comment.
Can you keep this function, and renmae it to waitOrderClear()
There was a problem hiding this comment.
should we public it, rename it to WaitOrderClear()? I think we should, so that strategies can take advantage of it
There was a problem hiding this comment.
I think we should only rename it when we are going to use it
|
would be great if you can rebase + fixup the commits, so the other branches won't conflict with these changes |
c9s
changed the title
|
Re-estimated karma: this pull request may get 666 BBG |
|
Hi @lanphan, Well done! 681 BBG has been sent to your polygon wallet. Please check the following tx: https://polygonscan.com/tx/0x0ff63858ee63ff570970e67f9f1999c1e2d1da9bfa20f35212266d60c189da8e Thank you for your contribution! |
No description provided.