FIX: [grid2] fix issue when recovering with finalizing orders #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome back! @kbearXD, This pull request may get 268 BBG. |
gx578007
approved these changes
Apr 2, 2024
c9s
reviewed
Apr 2, 2024
pkg/bbgo/order_executor_general.go
Outdated
| @@ -544,7 +545,8 @@ func (e *GeneralOrderExecutor) ClosePosition(ctx context.Context, percentage fix | |||
| if queryOrderService, ok := e.session.Exchange.(types.ExchangeOrderQueryService); ok && !IsBackTesting { | |||
| switch submitOrder.Type { | |||
| case types.OrderTypeMarket: | |||
| _, err2 := retry.QueryOrderUntilFilled(ctx, queryOrderService, createdOrders[0].Symbol, createdOrders[0].OrderID) | |||
| isMax := exchange.IsMaxExchange(e.session.Exchange) | |||
| _, err2 := retry.QueryOrderUntilFilled(ctx, queryOrderService, createdOrders[0].Symbol, createdOrders[0].OrderID, isMax) | |||
There was a problem hiding this comment.
can we not do this? this is a generic api
c9s
reviewed
Apr 2, 2024
kbearXD
force-pushed
the
kbearXD/grid2/fix-recover-with-finalizing-issue
branch
from
dd3a3f4 to
bfede2b
Compare
|
Re-estimated karma: this pull request may get 280 BBG |
kbearXD
force-pushed
the
kbearXD/grid2/fix-recover-with-finalizing-issue
branch
from
bfede2b to
fdba537
Compare
|
Re-estimated karma: this pull request may get 294 BBG |
c9s
reviewed
Apr 3, 2024
pkg/strategy/common/sync.go
Outdated
| @@ -26,6 +27,10 @@ func SyncActiveOrder(ctx context.Context, ex types.Exchange, orderQueryService t | |||
| return isOrderUpdated, err | |||
| } | |||
|
|
|||
| if updatedOrder == nil { | |||
| return isOrderUpdated, fmt.Errorf("updatedOrder is nil and there is no error, please check it") | |||
There was a problem hiding this comment.
use unexpected error, order object is a nil pointer, please check common.SyncActiveOrder()
c9s
approved these changes
Apr 3, 2024
|
Re-estimated karma: this pull request may get 309 BBG |
c9s
force-pushed
the
kbearXD/grid2/fix-recover-with-finalizing-issue
branch
from
1dbc748 to
444c228
Compare
|
Re-estimated karma: this pull request may get 314 BBG |
|
Hi @kbearXD, Well done! 319 BBG has been sent to your polygon wallet. Please check the following tx: https://polygonscan.com/tx/0x02b8cae2fed71a7ff7cc69ac8d15c1602e43a36551edc52d7a8167ea6161da27 Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.