FIX: simplify booksignal struct #1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome back! @c9s, This pull request may get 250 BBG. |
c9s
commented
Feb 5, 2024
| ) | ||
|
|
||
| type BookSignal struct { | ||
| Type BookSignalType | ||
| Book SliceOrderBook |
There was a problem hiding this comment.
take off this big struct, could be too big to copy
c9s
commented
Feb 5, 2024
| newTree := NewRBTree() | ||
| tree.InorderReverse(func(n *RBNode) bool { | ||
| if cnt >= limit { |
c9s
commented
Feb 5, 2024
| @@ -473,3 +464,23 @@ func (tree *RBTree) Print() { | |||
| return true | |||
| }) | |||
| } | |||
|
|
|||
| func copyNodeFast(newTree *RBTree) func(n *RBNode) bool { | |||
c9s
commented
Feb 5, 2024
| @@ -162,9 +162,7 @@ func (sb *StreamOrderBook) BindStream(stream Stream) { | |||
|
|
|||
| sb.Load(book) | |||
| sb.EmitSnapshot(book) | |||
|
|
|||
| // when it's snapshot, it's very important to push the snapshot signal to the caller | |||
| sb.C <- BookSignal{Type: BookSignalSnapshot, Book: book} | |||
bailantaotao
approved these changes
Feb 6, 2024
pkg/exchange/binance/parse.go
Outdated
| @@ -510,6 +510,8 @@ func parseDepthEvent(val *fastjson.Value) (*DepthEvent, error) { | |||
| Symbol: string(val.GetStringBytes("s")), | |||
| FirstUpdateID: val.GetInt64("U"), | |||
| FinalUpdateID: val.GetInt64("u"), | |||
| Bids: make(types.PriceVolumeSlice, 0, 50), | |||
gx578007
approved these changes
Feb 6, 2024
|
Hi @c9s, Well done! 315 BBG has been sent to your polygon wallet. Please check the following tx: https://polygonscan.com/tx/0x340c95f6c9e833e1b62dab842337e266a97c6a276bf73a49947ae51ffa43323c Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.