Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: [okx] support kline subscriptions #1519

Merged
merged 1 commit into from
Jan 30, 2024
Merged

FEATURE: [okx] support kline subscriptions #1519

merged 1 commit into from
Jan 30, 2024

Conversation

bailantaotao
Copy link
Collaborator

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @bailantaotao, This pull request may get 278 BBG.

@codecov Codecov
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 50 lines in your changes are missing coverage. Please review.

Comparison is base (e3208b3) 21.79% compared to head (f0ad014) 21.78%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1519      +/-   ##
==========================================
- Coverage   21.79%   21.78%   -0.02%     
==========================================
  Files         605      605              
  Lines       43851    43874      +23     
==========================================
  Hits         9557     9557              
- Misses      33612    33635      +23     
  Partials      682      682
Files Coverage Δ
pkg/exchange/okex/kline_stream.go 0.00% <0.00%> (ø)
pkg/exchange/okex/stream.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3208b3...f0ad014. Read the comment docs.

c9s
c9s reviewed Jan 30, 2024
View reviewed changes
pkg/exchange/okex/kline_stream.go
log.WithError(err).Error("subscribe error")
func (s *KLineStream) Connect(ctx context.Context) error {
if len(s.StandardStream.Subscriptions) == 0 {
log.Info("no subscriptions in kline")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warnf?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the kline stream is not always subscribed, i print the log with info

@bailantaotao bailantaotao merged commit b5cd5aa into main Jan 30, 2024
@bailantaotao bailantaotao deleted the edwin/okx/support-kline-stream branch January 30, 2024 06:53
@bbgokarma-bot
Copy link

Hi @bailantaotao,

Well done! 308 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0xb9828c47706c7ab54c09e54479b6a03f843562d31c976f6df7986447aa1c8a9b

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c9s c9s c9s approved these changes

@ycdesu ycdesu ycdesu approved these changes

@gx578007 gx578007 gx578007 approved these changes

@kbearXD kbearXD Awaiting requested review from kbearXD

@narumiruna narumiruna Awaiting requested review from narumiruna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bailantaotao @bbgokarma-bot @c9s @ycdesu @gx578007