Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: add parameter index to the Last method #1182

Merged
merged 1 commit into from
May 31, 2023
Merged

Conversation

c9s
Copy link
Owner

@c9s c9s commented May 31, 2023

The goal is to replace Index(i) with Last(i) to simplify the interface

Verified

This commit was signed with the committer’s verified signature.
@bbgokarma-bot
Copy link

Welcome back! @c9s, This pull request may get 1483 BBG.

@c9s c9s requested a review from gx578007 May 31, 2023 11:36
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #1182 (5515f58) into main (2a074ba) will increase coverage by 0.00%.
The diff coverage is 46.93%.

Impacted file tree graph

@@           Coverage Diff            @@
##             main    #1182    +/-   ##
========================================
  Coverage   20.85%   20.85%            
========================================
  Files         490      493     +3     
  Lines       34985    34810   -175     
========================================
- Hits         7295     7259    -36     
+ Misses      27120    26996   -124     
+ Partials      570      555    -15     
Impacted Files Coverage Δ
pkg/bbgo/exit_lower_shadow_take_profit.go 0.00% <0.00%> (ø)
pkg/bbgo/stop_ema.go 0.00% <0.00%> (ø)
pkg/bbgo/trend_ema.go 11.76% <0.00%> (ø)
pkg/datatype/floats/slice.go 28.00% <0.00%> (ø)
pkg/indicator/ad.go 0.00% <0.00%> (ø)
pkg/indicator/atrp.go 0.00% <0.00%> (ø)
pkg/indicator/cma.go 0.00% <0.00%> (ø)
pkg/indicator/fisher.go 0.00% <0.00%> (ø)
pkg/indicator/klingeroscillator.go 62.00% <0.00%> (+5.63%) ⬆️
pkg/indicator/line.go 0.00% <0.00%> (ø)
... and 61 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a074ba...5515f58. Read the comment docs.

@c9s c9s merged commit 10e84c1 into main May 31, 2023
@c9s c9s deleted the feature/v2indicator branch May 31, 2023 23:39
@bbgokarma-bot
Copy link

Hi @c9s,

Well done! 1493 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x40031c76e9624199dec80ec684a57b6280fc2552a1f20c83e108ce50e9ad3a09

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants