Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: move metrics to defer funciton #1153

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Conversation

kbearXD
Copy link
Collaborator

@kbearXD kbearXD commented Apr 18, 2023

No description provided.

@kbearXD kbearXD requested review from c9s and gx578007 April 18, 2023 07:13
@bbgokarma-bot
Copy link

Hi @kbearXD,

This pull request may get 207 BBG.

To receive BBG token, please left your polygon address as an issue comment in this pull request with the following format, e.g.,

polygon:0xAb5801a7D398351b8bE11C439e05C5B3259aeC9B

Once this pull request is merged, your BBG token will be sent to your wallet.

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #1153 (ed4e0b0) into main (68f54c0) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1153      +/-   ##
==========================================
- Coverage   19.91%   19.91%   -0.01%     
==========================================
  Files         453      453              
  Lines       34402    34403       +1     
==========================================
  Hits         6852     6852              
- Misses      27004    27005       +1     
  Partials      546      546              
Impacted Files Coverage Δ
pkg/strategy/grid2/recover.go 18.09% <0.00%> (-0.09%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68f54c0...ed4e0b0. Read the comment docs.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 218 BBG

@gx578007 gx578007 merged commit a06ed9e into main Apr 18, 2023
@gx578007 gx578007 deleted the grid2/feature/move-metrics branch April 18, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants