FEATURE: max get-order v3 api support client order id parameter #1147
+20
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kbearXD, This pull request may get 219 BBG. To receive BBG token, please left your polygon address as an issue comment in this pull request with the following format, e.g., Once this pull request is merged, your BBG token will be sent to your wallet. |
Codecov Report
@@ Coverage Diff @@
## main #1147 +/- ##
==========================================
- Coverage 19.98% 19.97% -0.01%
==========================================
Files 452 452
Lines 34248 34258 +10
==========================================
Hits 6843 6843
- Misses 26859 26869 +10
Partials 546 546
Continue to review full report in Codecov by Sentry.
|
c9s
reviewed
Apr 14, 2023
| request.Id(uint64(orderID)) | ||
| } | ||
|
|
||
| if len(q.ClientOrderID) != 0 { |
There was a problem hiding this comment.
No, because we already exclude the situation 'q.OrderID == 0 && q.ClientOrderID == 0'.
c9s
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.