Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grid2: use newClientOrderID only for max #1105

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

c9s
Copy link
Owner

@c9s c9s commented Mar 13, 2023

No description provided.

Verified

This commit was signed with the committer’s verified signature.
@c9s c9s requested a review from gx578007 March 13, 2023 13:28
@bbgokarma-bot
Copy link

Welcome back! @c9s, This pull request may get 212 BBG.

@c9s c9s enabled auto-merge March 13, 2023 13:32
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Merging #1105 (35ceda8) into main (83ba32b) will increase coverage by 0.00%.
The diff coverage is 87.23%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1105   +/-   ##
=======================================
  Coverage   19.90%   19.90%           
=======================================
  Files         433      433           
  Lines       33773    33778    +5     
=======================================
+ Hits         6722     6724    +2     
- Misses      26507    26509    +2     
- Partials      544      545    +1     
Impacted Files Coverage Δ
pkg/strategy/grid2/strategy.go 28.19% <50.00%> (+0.03%) ⬆️
pkg/fixedpoint/convert.go 44.76% <100.00%> (ø)
pkg/types/market.go 15.68% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b540fc...35ceda8. Read the comment docs.

@c9s c9s merged commit 4b3f00f into main Mar 13, 2023
@c9s c9s deleted the strategy/grid2/client-order-id-max branch March 13, 2023 13:47
@bbgokarma-bot
Copy link

Hi @c9s,

Well done! 222 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x6af95c63156aa603bae3776b6902de6d91b024460ed620265b22c136bc4d8e5a

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants