Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: [grid2] round down quoteQuantity/baseQuantity after the fee reduction #1086

Merged
merged 2 commits into from
Mar 7, 2023

Conversation

c9s
Copy link
Owner

@c9s c9s commented Mar 7, 2023

No description provided.

@c9s c9s requested review from kbearXD and gx578007 March 7, 2023 05:37
@bbgokarma-bot
Copy link

Welcome back! @c9s, This pull request may get 206 BBG.

@c9s c9s changed the title FIX: grid2: round down quoteQuantity/baseQuantity after the fee reduction FIX: [grid2] round down quoteQuantity/baseQuantity after the fee reduction Mar 7, 2023
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 216 BBG

@c9s c9s force-pushed the fix/grid2/quote-fee-rounding branch from 329c270 to 62eed96 Compare March 7, 2023 05:53
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 221 BBG

@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #1086 (329c270) into main (b04492a) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 329c270 differs from pull request most recent head 756a3bb. Consider uploading reports for the commit 756a3bb to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1086      +/-   ##
==========================================
- Coverage   19.41%   19.39%   -0.02%     
==========================================
  Files         433      433              
  Lines       33417    33414       -3     
==========================================
- Hits         6487     6481       -6     
- Misses      26387    26389       +2     
- Partials      543      544       +1     
Impacted Files Coverage Δ
pkg/strategy/grid2/strategy.go 27.60% <100.00%> (-0.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b04492a...756a3bb. Read the comment docs.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 236 BBG

@c9s c9s enabled auto-merge March 7, 2023 10:46
@c9s c9s merged commit f26568e into main Mar 7, 2023
@c9s c9s deleted the fix/grid2/quote-fee-rounding branch March 7, 2023 10:46
@bbgokarma-bot
Copy link

Hi @c9s,

Well done! 241 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x270f1040779a90bc493bb6e696065a3d7982bba73b889280dccdc8e91e968b60

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants