Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strategy: grid2: run backtest in test and add more details #1020

Merged
merged 8 commits into from
Dec 6, 2022
Merged

Conversation

c9s
Copy link
Owner

@c9s c9s commented Dec 6, 2022

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @c9s, This pull request may get 513 BBG.

@c9s c9s requested review from zenixls2 and austin362667 and removed request for zenixls2 December 6, 2022 05:21
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #1020 (2e1a0c5) into main (9cea38a) will increase coverage by 0.32%.
The diff coverage is 40.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1020      +/-   ##
==========================================
+ Coverage   18.88%   19.21%   +0.32%     
==========================================
  Files         412      414       +2     
  Lines       31677    31744      +67     
==========================================
+ Hits         5983     6100     +117     
+ Misses      25171    25096      -75     
- Partials      523      548      +25     
Impacted Files Coverage Δ
pkg/backtest/exchange.go 0.00% <0.00%> (ø)
pkg/backtest/utils.go 0.00% <0.00%> (ø)
pkg/strategy/grid2/strategy.go 48.88% <40.42%> (+13.22%) ⬆️
pkg/strategy/grid2/profit_stats.go 84.37% <84.37%> (ø)
pkg/strategy/grid2/profit.go 100.00% <100.00%> (+35.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cea38a...2e1a0c5. Read the comment docs.

@c9s c9s merged commit a763bd0 into main Dec 6, 2022
@c9s c9s deleted the feature/grid2 branch December 6, 2022 06:14
@bbgokarma-bot
Copy link

Hi @c9s,

Well done! 523 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x5c85aa0e54ed2f01a40db5b5106168bbd53baa593c6568f727c27bca7fcf31ef

Thank you for your contribution!

c9s added a commit that referenced this pull request Dec 12, 2022
c9s added a commit that referenced this pull request Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants