It should add splitting extra argument to newArgv #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c9s
approved these changes
Apr 13, 2023
c9s
reviewed
Apr 13, 2023
src/OptionParser.php
Outdated
| @@ -175,6 +174,11 @@ public function parse(array $argv) | |||
| } | |||
|
|
|||
| $spec = $this->specs->get($arg->getOptionName()); | |||
|
|
|||
| if ((string) $arg === '--') { | |||
There was a problem hiding this comment.
calling get value method might be better than casting object to string here
There was a problem hiding this comment.
Just notice that $arg->getOptionName() will get the - when the $arg is --.
|
added a comment |
peter279k
force-pushed
the
add_split_extra_arg
branch
from
f0c79b1 to
b2af7cd
Compare
peter279k
force-pushed
the
add_split_extra_arg
branch
from
b2af7cd to
3d8bd1d
Compare
c9s
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.