[WIP] Fix race condition between service account availability and webhook invocation #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roehrijn
force-pushed
the
roehrijn/fix-with-notification
branch
from
37ac32f to
91754ec
Compare
roehrijn
force-pushed
the
roehrijn/fix-with-notification
branch
from
91754ec to
79fcca1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In aws#174 a race condition is mentioned, where the webhook tries to mutate a Pod having a service account reference which is not yet populated to the ServiceAccountCache. This results in the pod being not mutated.
In our scenario this is a matter of a few milliseconds before the cache is properly populated.
As an alternative to aws#178, this PR tries to fix this by waiting for a certain amount of time for proper ServiceAccountCache population and being notified upon population.
Jan Roehrich [email protected], Mercedes-Benz Tech Innovation GmbH, legal info/Impressum