Skip to content

feat: add nightlight.sh, chained discover -> plan -> overnight wrapper - #23

Merged
c0d3ster merged 1 commit into
mainfrom
feat/nightlight-wrapper
Aug 6, 2026
Merged

feat: add nightlight.sh, chained discover -> plan -> overnight wrapper#23
c0d3ster merged 1 commit into
mainfrom
feat/nightlight-wrapper

Conversation

@c0d3ster

@c0d3ster c0d3ster commented Aug 6, 2026

Copy link
Copy Markdown
Owner

Summary

  • New nightlight.sh chains discover.sh -> plan.sh -> overnight.sh into one command (pnpm nightlight [repo]), reusing each script unchanged -- no new approval logic of its own.
  • --scan routes to discover.sh only; overnight.sh's five flags (--stop-after, --limit, --stack, --extra-instructions, --override-prompt) are captured generically and forwarded verbatim to the overnight.sh call, unvalidated by nightlight.sh -- overnight.sh stays the single source of truth for its own flag semantics.
  • A y/N confirmation gate sits only between plan and overnight (not between discover/plan, which are already fully interactive/approval-gated) -- overnight.sh is the one unattended, potentially hours-long, real-cost phase, so this is the one point a chained command should make you deliberately opt in rather than sliding straight into it.
  • package.json gains a nightlight script entry; README documents the new command.

Test plan

  • bash -n nightlight.sh -- syntax valid
  • Flag-routing logic dry-run across 5 cases (repo-only, --scan, overnight flags, no-repo --limit, unknown flag) -- all routed to the correct downstream script, unknown flag rejected before anything launches
  • package.json validated as well-formed JSON
  • Live end-to-end run of pnpm nightlight against a real PROJECT_REPOS_DIR (needs a real target-repo setup to exercise, same caveat as feat: add no-arg multi-repo mode to discover/plan, self-merging Finalize #20)

🤖 Generated with Claude Code

A single command running the full pipeline instead of three manual
invocations: pnpm nightlight [repo] chains discover.sh -> plan.sh ->
overnight.sh, using the exact same scripts under the hood (no new
approval logic -- discover/plan's existing interactive gates apply
unchanged).

- --scan is forwarded to discover.sh only.
- overnight.sh's five flags (--stop-after, --limit, --stack,
  --extra-instructions, --override-prompt) are captured generically
  and forwarded verbatim to the overnight.sh call, unvalidated by
  nightlight.sh itself -- overnight.sh remains the source of truth
  for what each flag means and requires.
- A y/N confirmation gate sits between plan and overnight specifically
  (not between discover and plan, which are already fully interactive
  and approval-gated): overnight is the one unattended, potentially
  hours-long, real-cost phase, so this is the one place a chained
  command should make you deliberately opt in. Declining exits 0 with
  a pointer to run overnight.sh manually later.
- package.json gains a "nightlight" script entry; README documents
  the new command (## nightlight.sh, Scripts, Usage, Setup).
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@c0d3ster, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 38 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5435a05a-f2f9-4825-8d87-9d4bf92dc963

📥 Commits

Reviewing files that changed from the base of the PR and between 15cff10 and 556d26e.

📒 Files selected for processing (3)
  • README.md
  • nightlight.sh
  • package.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@c0d3ster
c0d3ster merged commit 43f56ad into main Aug 6, 2026
1 check passed
@c0d3ster
c0d3ster deleted the feat/nightlight-wrapper branch August 6, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant