fix(plan): support self-targeting nightlight's own TASKS.md - #10
fix(plan): support self-targeting nightlight's own TASKS.md#10c0d3ster wants to merge 2 commits into
Conversation
plan.sh already resolved absolute paths that exist as directories, bypassing PROJECT_REPOS_DIR. But pointing it at nightlight's own repo root still passed that path to --add-dir on top of the identical cwd. Detect when the resolved REPO matches the current working directory and invoke /plan-tasks directly, since cwd files are already readable without --add-dir.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This reverts commit eaf7f2b.
|
Closing — turns out no fix was needed. I assumed pointing --add-dir at the same directory as cwd would be redundant/problematic, but I tested it directly ( |
* chore(tasks): number and stack self-targeting task list Assign #1-#10 task numbers and [stack] annotations to TASKS.md's Agent-Ready/Verify/Research/Decisions items for nightlight's self-improvement backlog. Introduce docs/nightlight-meta.json with nextTaskNumber: 11. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * chore: gitignore .claude/worktrees/ Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
Summary
plan.shalready resolved absolute paths that were real directories, bypassingPROJECT_REPOS_DIR— but pointing it at nightlight's own repo root still passed that same path to--add-dir, redundant with (and potentially conflicting with) the identical cwd.REPOmatches the current working directory (nightlight planning itself, per the existing rootTASKS.md) and invoke/plan-taskswith no--add-dirin that case, since cwd files are already readable without it.PROJECT_REPOS_DIR, or by absolute path) are unaffected — they still get--add-dir.Test plan
bash -n plan.sh— syntax checkclaudebinary:plan.sh .,plan.sh <absolute nightlight path>, andplan.sh other-repo(viaPROJECT_REPOS_DIR) all resolved to the expected invocationpnpm plan .from the nightlight repo, confirm/plan-tasksproposes a breakdown against nightlight's ownTASKS.md🤖 Generated with Claude Code