Skip to content

Conversation

@jmid
Copy link
Collaborator

@jmid jmid commented Mar 3, 2025

This PR

  • adjusts the avg and stddev computations to limit needless precision loss. It does so by adding summands by order of magnitude (smaller to larger),
  • it switches printing of avg and stddev to scientific notation once we go beyond 1e7, from the rationale that, e.g., stddev: 2660730801206827008.00 contains more decimals than are readable and that we have precision for,
  • it works around an annoying MinGW printing issue that inserts a leading exponent zero as in "1.859e+018" which needlessly caused expect tests to fail there, and
  • finally it reenables dune runtest on Windows

Fixes #293

@jmid jmid force-pushed the stddev-precision branch from 3faee4e to d7ac098 Compare March 5, 2025 23:17
@jmid
Copy link
Collaborator Author

jmid commented Mar 5, 2025

Rebased on main - and also fixed a bug in the 'remove-leading-zeros-from-float-exponent-for-consistent-printing' function cut_exp_zero.

@jmid jmid merged commit a8e8535 into c-cube:main Mar 6, 2025
13 checks passed
@jmid jmid deleted the stddev-precision branch March 6, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expect test failures on stddev under Windows

1 participant