Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add primitive defs for kintexuplus #65

Merged
merged 1 commit into from
Oct 6, 2017
Merged

Add primitive defs for kintexuplus #65

merged 1 commit into from
Oct 6, 2017

Conversation

bonddenhalter
Copy link
Collaborator

@bonddenhalter bonddenhalter commented Aug 7, 2017

There may be some issues with the way these were created in VSRT, because I had to make a few edits in the FamilyInfo file (adding HARD0GND bels to SLICEL and SLICEM sites), but aside from that they are correct and successfully installed in RapidSmith2. #3

Copy link
Collaborator

@bradselw bradselw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just like to point out that we don't have any good way to test changes like these, so all testing will have to be done manually. Please make sure you test out functions such as sites::get_site_wire_sinks that consume the .def files for this part.

@xrtc
Copy link

xrtc commented Aug 9, 2017

I would like to know in more detail why the familyInfo file had to be hand edited. Is this something that will happen in the future or was there a problem just this time that required it? If it can be avoided in the future, has the method for doing so been documented? I view this as extremely important to document.

@bonddenhalter
Copy link
Collaborator Author

@bradselw I'm not very experienced with Tincr. Could you give me some example code I could run to test out that function? I'm not sure how to obtain a source object to give it as a parameter.

@ttown523
Copy link
Collaborator

Dr. Nelson,

If you go through the entire process from scratch, the only hand edits for the family info file are adding a few compatible sites manually (two for UltraScale). Bond didn't need to add the new BELs manually, he could have created a new "addedBels.txt" file and added that file as a parameter to the "create_xml_family_info" function. As we stated in our previous meeting, for UltraScale devices there were no significant hand edits. This is also most likely true for UltraScale+, but we still have to do further device testing to ensure this.

@nelsobe nelsobe merged commit 7d68e48 into master Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants