Use Referer header #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshutch
reviewed
Oct 20, 2020
stuft2
previously approved these changes
Oct 20, 2020
stuft2
approved these changes
Oct 20, 2020
yoshutch
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #17. Rather than use an origin access identity, we use the
Refererheader between CloudFront and S3. CloudFront will forward theRefererheader with a random value (generated by therandomprovider) to the S3 bucket. The S3 bucket will deny all requests without that header. This again will force all legitimate traffic through the CloudFront distribution. While the S3 bucket can still be accessed directly, the caller would get a 403 error if it's missing that header.No functionality is removed in this PR. The breaking change is changing the resource name of the Route 53 records to standardize on the naming convention we use.
The added functionality includes adding the
Refererheader, setting a variable to force destroy buckets, encrypting buckets, and adding standard CloudFront logging (real-time logging is dependent on hashicorp/terraform-provider-aws#14974).