Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from aws_s3_bucket_object to aws_s3_object #66

Merged
merged 3 commits into from
Nov 2, 2022
Merged

Conversation

GaryGSC
Copy link
Member

@GaryGSC GaryGSC commented Oct 26, 2022

Looks like we missed some deprecated S3 resources in #65.

@GaryGSC
Copy link
Member Author

GaryGSC commented Oct 26, 2022

Well, shoot. Looks like this one isn't supported in AWS provider v3.75.2, but it still prints the deprecation notice. /sigh

We'll have to cut a major-version release for this.

@GaryGSC
Copy link
Member Author

GaryGSC commented Oct 26, 2022

Most of the S3 resources were backported. I guess they missed this one?

@github-actions
Copy link

github-actions bot commented Nov 2, 2022

Terraform Plan for ./examples/advanced:

will create 20 resources:

  • aws_cloudwatch_log_group - lambda_logs
  • aws_iam_policy - s3_access
  • aws_iam_role - test_lambda
  • aws_iam_role_policy - lambda_vpc_policy
  • aws_iam_role_policy - test_lambda
  • aws_iam_role_policy_attachment - s3_access
  • aws_lambda_function - test_lambda
  • aws_s3_bucket - postman_bucket
  • aws_s3_bucket - postman_bucket_logs
  • aws_s3_bucket_acl - postman_bucket_logs
  • aws_s3_bucket_lifecycle_configuration - postman_bucket
  • aws_s3_bucket_lifecycle_configuration - postman_bucket_logs
  • aws_s3_bucket_logging - postman_bucket
  • aws_s3_bucket_public_access_block - default
  • aws_s3_bucket_public_access_block - default_logs
  • aws_s3_bucket_server_side_encryption_configuration - postman_bucket
  • aws_s3_bucket_server_side_encryption_configuration - postman_bucket_logs
  • aws_s3_object - collections
  • aws_s3_object - environments
  • aws_security_group - lambda_vpc_sg

see details

@github-actions
Copy link

github-actions bot commented Nov 2, 2022

Terraform Plan for ./examples/simple:

will create 17 resources:

  • aws_cloudwatch_log_group - lambda_logs
  • aws_iam_policy - s3_access
  • aws_iam_role - test_lambda
  • aws_iam_role_policy - test_lambda
  • aws_iam_role_policy_attachment - s3_access
  • aws_lambda_function - test_lambda
  • aws_s3_bucket - postman_bucket
  • aws_s3_bucket - postman_bucket_logs
  • aws_s3_bucket_acl - postman_bucket_logs
  • aws_s3_bucket_lifecycle_configuration - postman_bucket
  • aws_s3_bucket_lifecycle_configuration - postman_bucket_logs
  • aws_s3_bucket_logging - postman_bucket
  • aws_s3_bucket_public_access_block - default
  • aws_s3_bucket_public_access_block - default_logs
  • aws_s3_bucket_server_side_encryption_configuration - postman_bucket
  • aws_s3_bucket_server_side_encryption_configuration - postman_bucket_logs
  • aws_s3_object - collections

see details

@GaryGSC
Copy link
Member Author

GaryGSC commented Nov 2, 2022

Since we're going to need AWS provider v4, we're going to need to cut a v5.0.0 release. And if we're going to cut a major version release, we might as well require Terraform v1.3.0. I expect that to be a pretty common breakpoint for a lot of other modules, since it introduces optional attributes in object variables.

@GaryGSC GaryGSC requested review from joshgubler, yoshutch and a team November 2, 2022 22:08
@GaryGSC GaryGSC merged commit be356bb into master Nov 2, 2022
@GaryGSC GaryGSC deleted the s3-object branch November 2, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants