Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nit: move attributions to NOTICE file #1

Merged
merged 1 commit into from
Jun 26, 2019
Merged

nit: move attributions to NOTICE file #1

merged 1 commit into from
Jun 26, 2019

Conversation

changlan
Copy link
Contributor

No description provided.

@ymjiang
Copy link
Member

ymjiang commented Jun 26, 2019 •
edited
Loading

LGTM.

@changlan changlan merged commit 4810f25 into master Jun 26, 2019
@changlan changlan deleted the notice branch June 26, 2019 05:25
ymjiang
ymjiang approved these changes Jun 26, 2019
View reviewed changes
Copy link
Member

@ymjiang ymjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@compete369 compete369 mentioned this pull request Jul 18, 2019
Closed
@ivanbrave ivanbrave mentioned this pull request Aug 6, 2019
Open
@bobzhuyb bobzhuyb mentioned this pull request Jan 17, 2020
Open
@ghost ghost mentioned this pull request Feb 25, 2020
Closed
@DeruiLiu DeruiLiu mentioned this pull request Aug 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymjiang ymjiang ymjiang approved these changes

@bobzhuyb bobzhuyb Awaiting requested review from bobzhuyb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@changlan @ymjiang