Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BytePS requires root permission #9

Closed
ppwwyyxx opened this issue Jun 27, 2019 · 4 comments
Closed

BytePS requires root permission #9

ppwwyyxx opened this issue Jun 27, 2019 · 4 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@ppwwyyxx
Copy link

Describe the bug
BytePS needs to create socket hard-coded at this path:

#define BASE_SOCKET_PATH_RECV "/usr/local/socket_recv_"
#define BASE_SOCKET_PATH_SEND "/usr/local/socket_send_"

As a result, BytePS cannot be used without root permission. Running BytePS without root permission gives:

[2019-06-27 11:01:05.326916: F byteps/common/communicator.cc:135] Check failed: (ret) >= (0) /usr/local/socket_send_0 bind failed: Permission denied
@bobzhuyb
Copy link
Member

bobzhuyb commented Jun 27, 2019

We will make these paths configurable. Also, maybe use /tmp/ as default path, though /tmp/ is a dangerous location for other reasons..

@bobzhuyb bobzhuyb added bug Something isn't working enhancement New feature or request labels Jun 27, 2019
@ymjiang
Copy link
Member

ymjiang commented Jun 28, 2019

Thank you for the report. I will keep you updated once this is fixed. @bobzhuyb Let me update the code.

@ymjiang ymjiang closed this as completed Jun 28, 2019
@ymjiang ymjiang reopened this Jun 28, 2019
@ymjiang
Copy link
Member

ymjiang commented Jun 28, 2019

@ppwwyyxx Commit 5dabf0c should fix this. The default path is changed to /tmp. You can also configure the path by setting BYTEPS_SOCKET_PATH to like /your/path.
Let me know if it works for you.

@ppwwyyxx
Copy link
Author

Thanks for the quick response!

pleasantrabbit pushed a commit that referenced this issue Jul 13, 2020
* wd: use Process

* wd: add log

* wd: fix bug

* wd: check context

* wd: add log

* wd: use threading.Thread

* wd: use deepcopy

* wd: fix

* wd: fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants