Skip to content

add devcontainer postCreateCommand to chown mount volumn#277

Merged
zhangxffff merged 1 commit intobytedance:mainfrom
zhangxffff:fix/devcontainer_volumn_permission
Mar 2, 2026
Merged

add devcontainer postCreateCommand to chown mount volumn#277
zhangxffff merged 1 commit intobytedance:mainfrom
zhangxffff:fix/devcontainer_volumn_permission

Conversation

@zhangxffff
Copy link
Copy Markdown
Collaborator

@zhangxffff zhangxffff commented Mar 2, 2026

What problem does this PR solve?

Issue Number: close #276

Fix conan and ccache permision problem when building Bolt in a new devcontainer with a freshly mounted volume.

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🚀 Performance improvement (optimization)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🔨 Refactoring (no logic changes)
  • 🔧 Build/CI or Infrastructure changes
  • 📝 Documentation only

Description

Add postCreateCommand in devcontainer.json to change owner of conan and ccache directory from root to code.

https://containers.dev/implementors/spec/#post-container-creation

Performance Impact

  • No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).

  • Positive Impact: I have run benchmarks.

    Click to view Benchmark Results
    Paste your google-benchmark or TPC-H results here.
    Before: 10.5s
    After:   8.2s  (+20%)
    
  • Negative Impact: Explained below (e.g., trade-off for correctness).

Checklist (For Author)

  • I have added/updated unit tests (ctest).
  • I have verified the code with local build (Release/Debug).
  • I have run clang-format / linters.
  • (Optional) I have run Sanitizers (ASAN/TSAN) locally for complex C++ changes.
  • No need to test or manual test.

Breaking Changes

  • No

  • Yes (Description: ...)

    Click to view Breaking Changes
    Breaking Changes:
    - Description of the breaking change.
    - Possible solutions or workarounds.
    - Any other relevant information.
    

@zhangxffff zhangxffff requested a review from ZacBlanco March 2, 2026 06:03
@zhangxffff zhangxffff enabled auto-merge March 2, 2026 06:03
@zhangxffff zhangxffff added this pull request to the merge queue Mar 2, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 2, 2026
@zhangxffff zhangxffff added this pull request to the merge queue Mar 2, 2026
Merged via the queue into bytedance:main with commit 60c5a57 Mar 2, 2026
6 checks passed
guhaiyan0221 pushed a commit to guhaiyan0221/bolt that referenced this pull request Mar 4, 2026
guhaiyan0221 pushed a commit to guhaiyan0221/bolt that referenced this pull request Mar 4, 2026
guhaiyan0221 pushed a commit to guhaiyan0221/bolt that referenced this pull request Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Chore] devcontainer volumn's file owner is root and cause build failed when access conan and ccache

2 participants