Skip to content

Remove C128 req slot allocation reset - #620

Merged
zhangxiaolei123456 merged 1 commit into
sync-pr-601-to-mainfrom
remove-c128-req-slot-reset-sync-pr-601
Jun 28, 2026
Merged

zhangxiaolei123456 merged 1 commit into
sync-pr-601-to-mainfrom
remove-c128-req-slot-reset-sync-pr-601

Conversation

@zhangxiaolei123456

@zhangxiaolei123456 zhangxiaolei123456 commented Jun 27, 2026 •

Copy link
Copy Markdown
Collaborator

Motivation

Modifications

Accuracy Tests

Speed Tests and Profiling

Checklist

Review and Merge Process

  1. Ping Merge Oncalls to start the process. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • Common commands include /tag-and-rerun-ci, /tag-run-ci-label, /rerun-failed-ci
  4. After green CI and required approvals, ask Merge Oncalls or people with Write permission to merge the PR.

CI States

Latest PR Test (Base): ❌ Run #28293208004
Latest PR Test (Extra): ❌ Run #28293207904

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request removes the _clear_c128_req_state_for_new_slots helper function and its usage from alloc_req_slots in common.py. In deepseek_v4_memory_pool.py, the batch clearing method clear_c128_req_states is removed, and the single-slot clearing method clear_c128_req_state is simplified to perform direct in-place tensor operations. Additionally, the associated unit test file has been deleted. I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@zhangxiaolei123456
zhangxiaolei123456 merged commit f5c0073 into sync-pr-601-to-main Jun 28, 2026
88 of 99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant