Skip to content

Reset C128 state on req slot allocation - #618

Merged
zhangxiaolei123456 merged 3 commits into
sync-pr-601-to-mainfrom
fix-dsv4-c128-req-slot-reset-sync-pr-601
Jun 25, 2026
Merged

zhangxiaolei123456 merged 3 commits into
sync-pr-601-to-mainfrom
fix-dsv4-c128-req-slot-reset-sync-pr-601

Conversation

@zhangxiaolei123456

@zhangxiaolei123456 zhangxiaolei123456 commented Jun 25, 2026 •

Copy link
Copy Markdown
Collaborator

Motivation

Modifications

Accuracy Tests

Speed Tests and Profiling

Checklist

Review and Merge Process

  1. Ping Merge Oncalls to start the process. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • Common commands include /tag-and-rerun-ci, /tag-run-ci-label, /rerun-failed-ci
  4. After green CI and required approvals, ask Merge Oncalls or people with Write permission to merge the PR.

CI States

Latest PR Test (Base): ❌ Run #28155292578
Latest PR Test (Extra): ❌ Run #28155292483

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the clearing of request-scoped C128 state for DeepSeek-V4. The clearing logic is moved from radix-cache prefix matching to request slot allocation, ensuring stale C128 state is cleared when a request slot is newly allocated while preserving state for reused slots (such as in chunked continuation). Additionally, the memory pool is updated to support batch clearing of states, and unit tests are updated to reflect these changes. I have no feedback to provide as there are no review comments.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@zhangxiaolei123456
zhangxiaolei123456 merged commit 5d4e944 into sync-pr-601-to-main Jun 25, 2026
88 of 99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant