Skip to content

Optimize online C128 state pool allocation using request state pool - #603

Merged
zhangxiaolei123456 merged 3 commits into
sync-pr-601-to-mainfrom
sync-pr-601-c128-request-state
Jun 19, 2026
Merged

zhangxiaolei123456 merged 3 commits into
sync-pr-601-to-mainfrom
sync-pr-601-c128-request-state

Conversation

@zhangxiaolei123456

@zhangxiaolei123456 zhangxiaolei123456 commented Jun 19, 2026 •

Copy link
Copy Markdown
Collaborator

Motivation

Modifications

Accuracy Tests

Speed Tests and Profiling

Checklist

Review and Merge Process

  1. Ping Merge Oncalls to start the process. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • Common commands include /tag-and-rerun-ci, /tag-run-ci-label, /rerun-failed-ci
  4. After green CI and required approvals, ask Merge Oncalls or people with Write permission to merge the PR.

CI States

Latest PR Test (Base): ❌ Run #27832417322
Latest PR Test (Extra): ❌ Run #27832417123

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the DeepSeek-V4 online C128 state handling to be request-scoped (indexed directly by the request pool index) rather than being indexed by token positions. It simplifies slot calculation in the CUDA kernels by directly using the request ID, updates the memory pool configurator to finalize the C128 state pool size based on the maximum running requests, and integrates the new C128_STATE state type into the disaggregation components. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@zhangxiaolei123456
zhangxiaolei123456 merged commit aa17574 into sync-pr-601-to-main Jun 19, 2026
85 of 97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant