Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI, again: borrow package-lock.json for github-release from elsewhere. #7

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

cfallin
Copy link
Member

@cfallin cfallin commented Sep 13, 2024

The copy of github-release we have was originally borrowed from Wizer's CI setup; let's take its package-lock.json file too, to see if this works. In contrast, on main right now we see this failure:

ERROR:  graphql_1.defaults is not a function
{}
TypeError: graphql_1.defaults is not a function
    at new GitHub
    (/action/node_modules/@actions/github/lib/github.js:23:34)
        at runOnce (/action/main.js:25:19)
            at run (/action/main.js:92:13)

…here.

The copy of github-release we have was originally borrowed from Wizer's
CI setup; let's take its package-lock.json file too, to see if this
works. In contrast, on `main` right now we see this failure:

```
ERROR:  graphql_1.defaults is not a function
{}
TypeError: graphql_1.defaults is not a function
    at new GitHub
    (/action/node_modules/@actions/github/lib/github.js:23:34)
        at runOnce (/action/main.js:25:19)
            at run (/action/main.js:92:13)
```
@cfallin cfallin requested a review from guybedford September 13, 2024 19:32
@cfallin cfallin merged commit aae7e84 into main Sep 13, 2024
10 checks passed
@cfallin cfallin deleted the cfallin/fix-ci branch September 13, 2024 19:43
cfallin added a commit that referenced this pull request Sep 13, 2024
This is another attempt at a release in the new repository location
(bytecodealliance/weval) with fixed CI in #6 and #7 to actually generate
binary artifacts.
@cfallin cfallin mentioned this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants