Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: release download urls without ratelimiting #14

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

guybedford
Copy link
Collaborator

@guybedford guybedford commented Nov 20, 2024

Resolves #13.

I've tested locally in ComponentizeJS that this works.

@guybedford
Copy link
Collaborator Author

I also ran Prettier against the JS code for consistent formatting.

Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much!

@cfallin cfallin merged commit 4c3059f into main Nov 20, 2024
11 checks passed
@cfallin cfallin deleted the fixup-release-downloads branch November 20, 2024 18:22
@cfallin
Copy link
Member

cfallin commented Nov 20, 2024

@guybedford if you're willing to cut a release, it might be a good exercise to make sure someone else can do it too -- the checklist in README.md should be up-to-date (feel free to ping me on Zulip if any issues!).

@vados-cosmonic
Copy link
Contributor

Ah OK -- was working on this and added a test to make sure it keeps working, will open up a separate PR for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoiding GitHub rate limits for npm library
3 participants