Skip to content

Conversation

@alexcrichton
Copy link
Member

This is a test to see what breaks in CI when updating to the 2024 edition. The edition won't actually be released until February of this year and we won't be able to use it until two releases after that. This is just a test in the meantime to smooth the future transition.

This is a test to see what breaks in CI when updating to the 2024
edition. The edition won't actually be released until February of this
year and we won't be able to use it until two releases after that. This
is just a test in the meantime to smooth the future transition.
prtest:full
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:meta Everything related to the meta-language. labels Jan 10, 2025
@alexcrichton
Copy link
Member Author

Learnings here:

  • A few miscellaneous things were split out here and there (e.g. failing doctests)
  • Looks like this is going to be a "reformat the world" transition, presumably due to newer defaults in rustfmt
  • The windows-specific failures are due to Win: Use POSIX rename semantics for std::fs::rename if available rust-lang/rust#131072, not the edition itself, and that's coming in 1.85. We'll just need to update some tests to expect success instead of expecting failure.

Otherwise I think we're bsaically good to go 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cranelift:meta Everything related to the meta-language. cranelift Issues related to the Cranelift code generator

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant