Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement subtype checking for [return_]call_indirect instructions #9448

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Implement subtype checking for [return_]call_indirect instructions #9448

merged 2 commits into from
Oct 10, 2024
+79 −48

Commits on Oct 10, 2024

  1. Implement subtype checking for [return_]call_indirect instructions 

    When Wasm GC is enabled, the `[return_]call_indirect` instructions must do full
subtyping checks, rather than simple strict equality type checks.

This adds an additional branch and slow path to indirect calls, so we only emit
code for this check when Wasm GC is enabled, even though it would otherwise be
correct to always emit it (because the `is_subtype` check would always fail for
non-equal types, since there is no subtyping before Wasm GC).
    @fitzgen
    fitzgen committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    b89dcb6 View commit details
    Browse the repository at this point in the history

  2. fix no-gc builds

    @fitzgen
    fitzgen committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    91634f5 View commit details
    Browse the repository at this point in the history