Rename the wasmtime::runtime::vm::Instance::module method to env_module
#9261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fitzgen
requested review from
elliottt and
alexcrichton
and removed request for
a team and
elliottt
…odule` Because it returns the `wasmtime_environ::Module`. This paves the way for a new method to get the `wasmtime::Module`.
fitzgen
force-pushed
the
rename-instance-module-accessor
branch
from
0459184
to
e94589b
Compare
alexcrichton
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because it returns the
wasmtime_environ::Module.This paves the way for a new method to get the
wasmtime::Module.