Wasmtime: Allow compiling Wasm modules with Pulley #9240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not yet add support for running Wasm modules compiled with Pulley, but it does allow compiling them. This is a first step towards integrating Pulley into Wasmtime itself. This is also enough to get basic `tests/disas` tests working with Pulley.
fitzgen
requested review from
pchickey and
alexcrichton
and removed request for
a team and
pchickey
alexcrichton
approved these changes
Sep 13, 2024
| let mut ret = CompileInputs { | ||
| need_wasm_to_array_trampolines: !matches!( | ||
| triple.architecture, | ||
| target_lexicon::Architecture::Pulley32 | target_lexicon::Architecture::Pulley64 |
There was a problem hiding this comment.
Do you think it's worth having for example an extension trait on TargetTriple for .is_pulley() to use here and in wasmtime-environ as well? Not that this set of architectures is going to change over time really
There was a problem hiding this comment.
Good idea, will do in a follow up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not yet add support for running Wasm modules compiled with Pulley, but it does allow compiling them via
wasmtime compile. This is a first step towards integrating Pulley into Wasmtime itself.This is also enough to get basic
tests/disastests working with Pulley.