Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasi-http] Return none from future-trailers.get when trailers absent #9208

Merged
merged 2 commits into from
Sep 6, 2024
Merged

[wasi-http] Return none from future-trailers.get when trailers absent #9208

merged 2 commits into from
Sep 6, 2024

Commits on Sep 6, 2024

  1. [wasi-http] Return none from future-trailers.get when trailers ab… 

    …sent

Previously, we would return `error-code::connection-terminated` in this case,
whereas the `wasi-http` spec says we should simply return `none` (i.e. it's not
an error if there are no trailers present).

This also adds code to `api_proxy_streaming.rs` to check for trailers after
reading the body content.

Signed-off-by: Joel Dice <[email protected]>
    @dicej
    dicej committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    20136ad View commit details
    Browse the repository at this point in the history

  2. minor code cleanup 

    Signed-off-by: Joel Dice <[email protected]>
    @dicej
    dicej committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    9efaf38 View commit details
    Browse the repository at this point in the history