Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vtune: smoke test profiling in CI #9185

Merged
merged 4 commits into from
Sep 6, 2024
Merged

vtune: smoke test profiling in CI #9185

merged 4 commits into from
Sep 6, 2024

Commits on Sep 6, 2024

  1. vtune: check that VTune profiling works 

    This adds a smoke test for checking that the VTune functionality still
works.
- if `vtune` is not on the system path, skip the test
- if it is, run Wasmtime with VTune profiling enabled
- check that it captured the CPU time and didn't fail.

This test doesn't rigorously check all the ins and outs of the VTune
functionality but is better than before.
    @abrown
    abrown committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    2590eb0 View commit details
    Browse the repository at this point in the history

  2. ci: install VTune 

    In order to actually run the VTune CLI test, we need `vtune` on the
system. The `install-vtune-action` I created does this ([script]).

[script]: https://github.com/abrown/install-vtune-action/blob/main/install.sh
    @abrown
    abrown committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    37cb9ab View commit details
    Browse the repository at this point in the history

  3. ci: further restrict workflow runs 

    Running the VTune installation and CLI test on any `ubuntu` runner meant
that even test runs for `riscv64` (emulated on QEMU) would attempt this.
Instead, restrict this test only to `linux-x64` runs.

prtest:full
    @abrown
    abrown committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    81e1d40 View commit details
    Browse the repository at this point in the history

  4. review: add cfg(target_arch)

    @abrown
    abrown committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    2e4ed61 View commit details
    Browse the repository at this point in the history