-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cranelift: Remove the old stack maps implementation #9159
Conversation
They are superseded by the new user stack maps implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
print_relocs(&func.params, relocs), | ||
print_traps(traps), | ||
print_stack_maps(stack_maps) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can cranelift-tool print user stackmaps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The vcode's debug implementation should include the stack maps:
wasmtime/cranelift/filetests/filetests/isa/x64/user_stack_maps.clif
Lines 55 to 68 in 9d35545
; call User(userextname0) | |
; ; UserStackMap { by_type: [(types::I32, CompoundBitSet {0, 4, 8})], sp_to_sized_stack_slots: None } | |
; lea rsp(0 + virtual offset), %rcx | |
; movl $1, 0(%rcx) | |
; lea rsp(4 + virtual offset), %rdx | |
; movl $2, 0(%rdx) | |
; movq %r15, %rdi | |
; call User(userextname0) | |
; ; UserStackMap { by_type: [(types::I32, CompoundBitSet {0, 4})], sp_to_sized_stack_slots: None } | |
; lea rsp(0 + virtual offset), %r9 | |
; movl $2, 0(%r9) | |
; movq %rbx, %rdi | |
; call User(userextname0) | |
; ; UserStackMap { by_type: [(types::I32, CompoundBitSet {0})], sp_to_sized_stack_slots: None } |
They are superseded by the new user stack maps implementation.