Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cranelift: Remove the old stack maps implementation #9159

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

fitzgen
Copy link
Member

@fitzgen fitzgen commented Aug 20, 2024

They are superseded by the new user stack maps implementation.

They are superseded by the new user stack maps implementation.
@fitzgen fitzgen requested a review from a team as a code owner August 20, 2024 22:31
@fitzgen fitzgen requested review from elliottt and removed request for a team August 20, 2024 22:31
Copy link
Member

@elliottt elliottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@fitzgen fitzgen added this pull request to the merge queue Aug 21, 2024
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:machinst Issues related to instruction selection and the new MachInst backend. cranelift:area:aarch64 Issues related to AArch64 backend. cranelift:area:x64 Issues related to x64 codegen labels Aug 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 21, 2024
@fitzgen fitzgen added this pull request to the merge queue Aug 21, 2024
Merged via the queue into bytecodealliance:main with commit c0c3a68 Aug 21, 2024
69 checks passed
@fitzgen fitzgen deleted the remove-old-stack-maps branch August 21, 2024 15:49
print_relocs(&func.params, relocs),
print_traps(traps),
print_stack_maps(stack_maps)
Copy link
Contributor

@bjorn3 bjorn3 Aug 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can cranelift-tool print user stackmaps?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The vcode's debug implementation should include the stack maps:

; call User(userextname0)
; ; UserStackMap { by_type: [(types::I32, CompoundBitSet {0, 4, 8})], sp_to_sized_stack_slots: None }
; lea rsp(0 + virtual offset), %rcx
; movl $1, 0(%rcx)
; lea rsp(4 + virtual offset), %rdx
; movl $2, 0(%rdx)
; movq %r15, %rdi
; call User(userextname0)
; ; UserStackMap { by_type: [(types::I32, CompoundBitSet {0, 4})], sp_to_sized_stack_slots: None }
; lea rsp(0 + virtual offset), %r9
; movl $2, 0(%r9)
; movq %rbx, %rdi
; call User(userextname0)
; ; UserStackMap { by_type: [(types::I32, CompoundBitSet {0})], sp_to_sized_stack_slots: None }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift:area:aarch64 Issues related to AArch64 backend. cranelift:area:machinst Issues related to instruction selection and the new MachInst backend. cranelift:area:x64 Issues related to x64 codegen cranelift Issues related to the Cranelift code generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants