cranelift-jit: implement GOT relocations for aarch64#7584
Merged
elliottt merged 1 commit intobytecodealliance:mainfrom Nov 27, 2023
Merged
cranelift-jit: implement GOT relocations for aarch64#7584elliottt merged 1 commit intobytecodealliance:mainfrom
elliottt merged 1 commit intobytecodealliance:mainfrom
Conversation
github-actions
bot
added
the
cranelift
elliottt
reviewed
Nov 27, 2023
Member
elliottt
left a comment
elliottt
left a comment
There was a problem hiding this comment.
Happy to approve after the offsets are removed, thank you!
Mrmaxmeier
force-pushed
the
aarch64-got-relocs
branch
from
23ace96 to
8b49150
Compare
Mrmaxmeier
force-pushed
the
aarch64-got-relocs
branch
from
8b49150 to
bb0515b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a prerequisite for #2735, but doesn't implement the PLT entries yet.
(I'm using hot function replace, which happens in the GOT but doesn't strictly require the PLT.)
The instruction encoding for
adrpis kind of complicated, but re-using existing lowering infrastructure doesn't work well since it's not designed to do partial updates. Xref: #5550, which introduced these relocation types.