Skip to content

Preserve uext and sext flags for parameters on x86_64 and apple aarch64 #7325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2023
Merged

Preserve uext and sext flags for parameters on x86_64 and apple aarch64 #7325

merged 1 commit into from
Oct 23, 2023

Conversation

@bjorn3
Copy link
Contributor

@bjorn3 bjorn3 commented Oct 22, 2023

This is required by the ABI and prevents a miscompilation when calling LLVM compiled functions.

Fixes #7210
Fixes https://github.com/bjorn3/rustc_codegen_cranelift/issues/1395

@bjorn3 bjorn3 requested a review from a team as a code owner October 22, 2023 15:20
@bjorn3 bjorn3 requested review from cfallin and removed request for a team October 22, 2023 15:20
@bjorn3
Preserve uext and sext flags for parameters on x86_64 and apple aarch64
06e308e 
This is required by the ABI and prevents a miscompilation when calling
LLVM compiled functions.
@bjorn3 bjorn3 force-pushed the fix_x86_uext_sext_args branch from d295399 to 06e308e Compare October 22, 2023 15:58
@bjorn3
Copy link
Contributor Author

bjorn3 commented Oct 22, 2023

Moved it from a precise-output test to a regular compile test as precise-output doesn't allow any comments.

@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:aarch64 Issues related to AArch64 backend. cranelift:area:x64 Issues related to x64 codegen labels Oct 22, 2023
@bjorn3 bjorn3 mentioned this pull request Oct 22, 2023
Merged
@bjorn3
Copy link
Contributor Author

bjorn3 commented Oct 22, 2023

If possible a patch release with this would be nice. It is the last known miscompilation in cg_clif and IMO a blocker for rust-lang/rust#81746.

alexcrichton
alexcrichton approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! And yeah I think a point release is ok for this. Would you be ok doing the backport?

@alexcrichton alexcrichton added this pull request to the merge queue Oct 23, 2023
@bjorn3
Copy link
Contributor Author

bjorn3 commented Oct 23, 2023

Sure

@bjorn3 bjorn3 mentioned this pull request Oct 23, 2023
Merged
@bjorn3
Copy link
Contributor Author

bjorn3 commented Oct 23, 2023

#7333

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 23, 2023
@alexcrichton alexcrichton added this pull request to the merge queue Oct 23, 2023
@bjorn3
Copy link
Contributor Author

bjorn3 commented Oct 23, 2023

Spurious network error?

curl: (56) OpenSSL SSL_read: error:0A000126:SSL routines::unexpected eof while reading, errno 0

@alexcrichton
Copy link
Member

Yeah downloading doxygen is occasionally flaky and weird. I requeued this and it should merge in the next few minutes

Merged via the queue into bytecodealliance:main with commit a5d9bbe Oct 23, 2023
@bjorn3 bjorn3 deleted the fix_x86_uext_sext_args branch October 23, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcrichton alexcrichton alexcrichton approved these changes

@cfallin cfallin Awaiting requested review from cfallin cfallin is a code owner automatically assigned from bytecodealliance/wasmtime-compiler-reviewers

Assignees

No one assigned

Labels

cranelift:area:aarch64 Issues related to AArch64 backend. cranelift:area:x64 Issues related to x64 codegen cranelift Issues related to the Cranelift code generator

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cranelift: Zero and sign extension unimplemented on x86_64 Miscompilation of std::thread::scope on x86_64 with llvm sysroot

2 participants

@bjorn3 @alexcrichton