Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cranelift to 0.52.0 #710

Merged
merged 2 commits into from
Dec 31, 2019

Conversation

abrown
Copy link
Contributor

@abrown abrown commented Dec 13, 2019

This PR is a bit premature (since Cranelift v0.52.0 has not yet been published) but as I attempt to get SIMD spec tests working I need changes like these to build my locally-changing copy of Cranelift. In talking to @yurydelendik I agreed to push these, but please note the unimplemented! used in the newly-exposed methods.

[edit: this PR should be good for review now that 0.52.0 is published]

@abrown abrown force-pushed the bump-cranelift branch 2 times, most recently from 589194e to 548b7c0 Compare December 18, 2019 17:10
@abrown abrown marked this pull request as ready for review December 18, 2019 17:22
@abrown
Copy link
Contributor Author

abrown commented Dec 18, 2019

It looks like wasi_tests are failing on test (beta)--@sunfishcode, any ideas?

@kubkon
Copy link
Member

kubkon commented Dec 19, 2019

It looks like wasi_tests are failing on test (beta)--@sunfishcode, any ideas?

It's also failing on nightly. This looks like an ABI incompatibility. Perhaps @alexcrichton will have more ideas about this?

@kubkon
Copy link
Member

kubkon commented Dec 20, 2019

@abrown @alexcrichton I’ll update the remaining WASI tests to use the latest wasi crate and this should make the CI green again. I’ll cc you guys in when the PR is ready and @abrown you’ll be able to rebase onto it for your PR to pass the CI.

@alexcrichton
Copy link
Member

I think it's probably best to disable the wasi tests on beta for now, we can re-enable when it's fixed again. I believe the current bug is rust-lang/rust#67363 and needs to be fixed by either (a) moving everything to the wasi crate or (b) waiting for that PR to land. I'm not 100% certain though about whether that PR will simply fix things, soin the meantime feel free to disable beta to land things in the interim.

@kubkon
Copy link
Member

kubkon commented Dec 20, 2019

I think it's probably best to disable the wasi tests on beta for now, we can re-enable when it's fixed again. I believe the current bug is rust-lang/rust#67363 and needs to be fixed by either (a) moving everything to the wasi crate or (b) waiting for that PR to land. I'm not 100% certain though about whether that PR will simply fix things, soin the meantime feel free to disable beta to land things in the interim.

I've now migrated all WASI test programs to wasi 0.9.0 in #743, so we should be green with the test jobs. However, now Emscripten job started failing also, and I'm wondering what to do. I suggested to @sunfishcode that we could either disable it or move the job from stable to nightly toolchain to get rust-lang/rust#66308 quicker. Thoughts?

EDIT: Oh, oops, I think I've mixed the two Rust PRs. So now I'm wondering whether Emscripten is failing because of rust-lang/rust#66308 or rust-lang/rust#67363...

@kubkon
Copy link
Member

kubkon commented Dec 20, 2019

@abrown @alexcrichton I've now filed #744 which disables the Emscripten job until rust-lang/rust#66308 is resolved.

@abrown abrown force-pushed the bump-cranelift branch 2 times, most recently from b15efb9 to 9bfbf1f Compare December 22, 2019 01:50
@abrown
Copy link
Contributor Author

abrown commented Dec 22, 2019

@kubkon, I rebased on your merged #744 but it still fails; did #744 fix the issue because I still see failures on HEAD?

@kubkon
Copy link
Member

kubkon commented Dec 22, 2019

@abrown oh sorry, we still need #743 to land for the CI to be completely in the green.

Cranelift changes to FuncEnvironment, TargetEnvironment, and GlobalInit (see bytecodealliance/cranelift#1073) require these changes to compile wasmtime.
@yurydelendik yurydelendik merged commit 69683e8 into bytecodealliance:master Dec 31, 2019
@yurydelendik
Copy link
Contributor

Thank you.

@abrown abrown deleted the bump-cranelift branch January 3, 2020 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants