Enhance `async` configuration of `bindgen!` macro #6942

alexcrichton · 2023-08-31T14:30:04Z

This commit takes a leaf out of wiggle's book to enable bindings
generation for async host functions where only some host functions are
async instead of all of them. This enhances the async key with a few
more options:

async: {
    except_imports: ["foo"],
    only_imports: ["bar"],
}

This is beyond what wiggle supports where either an allow-list or
deny-list can be specified (although only one can be specified). This
can be useful if either the list of sync imports or the list of async
imports is small.

yowl · 2023-08-31T15:12:13Z

"This is done thinking that the majority of functions probably want to be async" in real life this may be true. For tests however, if the target runtime, and I'm concerned with dotnet CoreCLR, requires WASI support then we need to run the wit-bindgen runtime tests with async support and while I'm not sure of the extent of the async requirements yet, it may just be the Instantiate function. Just a comment really, I can add all the test methods to the exclude list.

yowl · 2023-08-31T15:19:06Z

Actually thinking about this a bit more, as the tests are "round trip" and the import list is the same as the export list, if I have to change all the tests to async (because exports are always async), then I don't think this PR really affects me: I've got to change the test implementation signatures anyway.

alexcrichton · 2023-08-31T15:20:44Z

Good point! I think I'll update to:

bindgen!({
    async: true,
    async: false,
    async: {
        except_imports: ["..."],
        only_imports: ["..."],
    }
});

to handle that case. That also keeps everything in the async key which I like better.

This commit takes a leaf out of `wiggle`'s book to enable bindings generation for async host functions where only some host functions are async instead of all of them. This enhances the `async` key with a few more options: async: { except_imports: ["foo"], only_imports: ["bar"], } This is beyond what `wiggle` supports where either an allow-list or deny-list can be specified (although only one can be specified). This can be useful if either the list of sync imports or the list of async imports is small.

alexcrichton · 2023-08-31T15:32:45Z

Ok I've updated with a new syntax which has either "only these imports" or "except these imports" options which I think should handle your case @yowl

alexcrichton · 2023-08-31T15:34:35Z

Oh oops I didn't see your latest comment until just now, well in any case I think this is a better syntax regardless!

pchickey · 2023-08-31T16:35:28Z

Thanks! This will help in many places

…6950) * Enhance `async` configuration of `bindgen!` macro (#6942) This commit takes a leaf out of `wiggle`'s book to enable bindings generation for async host functions where only some host functions are async instead of all of them. This enhances the `async` key with a few more options: async: { except_imports: ["foo"], only_imports: ["bar"], } This is beyond what `wiggle` supports where either an allow-list or deny-list can be specified (although only one can be specified). This can be useful if either the list of sync imports or the list of async imports is small. * cranelift-interpreter: Fix SIMD shifts and rotates (#6939) * cranelift-interpreter: Fix SIMD `ishl`/`{s,u}`shr * fuzzgen: Enable a few more ops * cranelift: Fix tests for {u,s}shr * fuzzgen: Change pattern matching arms for shifts Co-Authored-By: Jamey Sharp <[email protected]> --------- Co-authored-by: Jamey Sharp <[email protected]> * Partially revert CLI argument changes from #6737 (#6944) * Partially revert CLI argument changes from #6737 This commit is a partial revert of #6737. That change was reverted in #6830 for the 12.0.0 release of Wasmtime and otherwise it's currently slated to get released with the 13.0.0 release of Wasmtime. Discussion at today's Wasmtime meeting concluded that it's best to couple this change with #6925 as a single release rather than spread out across multiple releases. This commit is thus the revert of #6737, although it's a partial revert in that I've kept many of the new tests added to showcase the differences before/after when the change lands. This means that Wasmtime 13.0.0 will exhibit the same CLI behavior as 12.0.0 and all prior releases. The 14.0.0 release will have both a new CLI and new argument passing semantics. I'll revert this revert (aka re-land #6737) once the 13.0.0 release branch is created and `main` becomes 14.0.0. * Update release notes * riscv64: Use `PCRelLo12I` relocation on Loads (#6938) * riscv64: Use `PCRelLo12I` relocation on Loads * riscv64: Strenghten pattern matching when emitting Load's * riscv64: Clarify some of the load address logic * riscv64: Even stronger matching * Update Rust in CI to 1.72.0, clarify Wasmtime's MSRV (#6900) * Update Rust in CI to 1.72.0 * Update CI, tooling, and docs for MSRV This commit codifies an MSRV policy for Wasmtime at "stable minus two" meaning that the latest three releases of Rust will be supported. This is enforced on CI with a full test suite job running on Linux x86_64 with the minimum supported Rust version. The full test suite will use the latest stable version. A downside of this approach is that new changes may break MSRV support on non-Linux or non-x86_64 platforms and we won't know about it, but that's deemed a minor enough risk at this time. A minor fix is applied to Wasmtime's `Cargo.toml` to support Rust 1.70.0 instead of requiring Rust 1.71.0 * Fix installation of rust * Scrape MSRV from Cargo.toml * Cranelift is the same as Wasmtime's MSRV now, more words too * Fix a typo * aarch64: Use `RegScaled*` addressing modes (#6945) This commit adds a few cases to `amode` construction on AArch64 for using the `RegScaled*` variants of `AMode`. This won't affect wasm due to this only matching the sign-extension happening before the shift, but it should otherwise help non-wasm Cranelift use cases. Closes #6742 * cranelift: Validate `iconst` ranges (#6850) * cranelift: Validate `iconst` ranges Add the following checks: `iconst.i8` immediate must be within 0 .. 2^8-1 `iconst.i16` immediate must be within 0 .. 2^16-1 `iconst.i32` immediate must be within 0 .. 2^32-1 Resolves #3059 * cranelift: Parse `iconst` according to its type Modifies the parser for textual CLIF so that V in `iconst.T V` is parsed according to T. Before this commit, something like `iconst.i32 0xffff_ffff_ffff` was valid because all `iconst` were parsed the same as an `iconst.i64`. Now the above example will throw an error. Also, a negative immediate as in `iconst.iN -X` is now converted to `2^N - X`. This commit also fixes some broken tests. * cranelift: Update tests to match new CLIF parser * Some minor fixes and features for WASI and sockets (#6948) * Use `command::add_to_linker` in tests to reduce the number of times all the `add_to_linker` are listed. * Add all `wasi:sockets` interfaces currently implemented to both the sync and async `command` functions (this enables all the interfaces in the CLI for example). * Use `tokio::net::TcpStream::try_io` whenever I/O is performed on a socket, ensuring that readable/writable flags are set/cleared appropriately (otherwise once readable a socket is infinitely readable). * Add a `with_ambient_tokio_runtime` helper function to use when creating a `tokio::net::TcpStream` since otherwise it panics due to a lack of active runtime in a synchronous context. * Add `WouldBlock` handling to return a 0-length read. * Add an `--inherit-network` CLI flag to enable basic usage of sockets in the CLI. This will conflict a small amount with #6877 but should be easy to resolve, and otherwise this targets different usability points/issues than that PR. --------- Co-authored-by: Afonso Bordado <[email protected]> Co-authored-by: Jamey Sharp <[email protected]> Co-authored-by: Timothée Jourde <[email protected]>

) This commit takes a leaf out of `wiggle`'s book to enable bindings generation for async host functions where only some host functions are async instead of all of them. This enhances the `async` key with a few more options: async: { except_imports: ["foo"], only_imports: ["bar"], } This is beyond what `wiggle` supports where either an allow-list or deny-list can be specified (although only one can be specified). This can be useful if either the list of sync imports or the list of async imports is small.

alexcrichton requested a review from a team as a code owner August 31, 2023 14:30

alexcrichton requested review from pchickey and removed request for a team August 31, 2023 14:30

alexcrichton force-pushed the bindgen-some-sync-imports branch from 20e85c9 to 1954f31 Compare August 31, 2023 15:32

pchickey approved these changes Aug 31, 2023

View reviewed changes

alexcrichton added this pull request to the merge queue Aug 31, 2023

Merged via the queue into bytecodealliance:main with commit 326837d Aug 31, 2023
18 checks passed

alexcrichton deleted the bindgen-some-sync-imports branch August 31, 2023 17:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enhance `async` configuration of `bindgen!` macro #6942

Enhance `async` configuration of `bindgen!` macro #6942

alexcrichton commented Aug 31, 2023 •

edited

Loading

yowl commented Aug 31, 2023 •

edited

Loading

yowl commented Aug 31, 2023

alexcrichton commented Aug 31, 2023

alexcrichton commented Aug 31, 2023

alexcrichton commented Aug 31, 2023

pchickey commented Aug 31, 2023

Enhance async configuration of bindgen! macro #6942

Enhance async configuration of bindgen! macro #6942

Conversation

alexcrichton commented Aug 31, 2023 • edited Loading

yowl commented Aug 31, 2023 • edited Loading

yowl commented Aug 31, 2023

alexcrichton commented Aug 31, 2023

alexcrichton commented Aug 31, 2023

alexcrichton commented Aug 31, 2023

pchickey commented Aug 31, 2023

Enhance `async` configuration of `bindgen!` macro #6942

Enhance `async` configuration of `bindgen!` macro #6942

alexcrichton commented Aug 31, 2023 •

edited

Loading

yowl commented Aug 31, 2023 •

edited

Loading