Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Wasmtime ABIs from Cranelift #6649

Merged
merged 5 commits into from
Jun 28, 2023

Commits on Jun 27, 2023

  1. Remove Wasmtime ABIs from Cranelift

    This commit removes the `Wasmtime*` family of ABIs from Cranelift. These
    were originally added to support multi-value in Wasmtime via the
    `TypedFunc` API, but they should now no longer be necessary. In general
    this is a higher-level Wasmtime concern than something all backends of
    Cranelift should have to deal with.
    
    Today with recent refactorings it's possible to remove the reliance on
    ABI details for multi-value and instead codify it directly into the
    Cranelift IR generated. For example wasm calls are able to have a
    "purely internal" ABI which Wasmtime's Rust code doesn't see at all, and
    the Rust code only interacts with the native ABI. The native ABI is
    redefined to be what the previous Wasmtime ABIs were, which is to return
    the first of a 2+ value return through a register (native return value)
    and everything else through a return pointer.
    alexcrichton committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    d18e287 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    82f443a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    34ff484 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. Configuration menu
    Copy the full SHA
    9325a02 View commit details
    Browse the repository at this point in the history
  2. Fix another doc link

    alexcrichton committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    38721f4 View commit details
    Browse the repository at this point in the history