Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android release binaries #6480

Closed
wants to merge 12 commits into from
Closed

Android release binaries #6480

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0a9fb5b
Added two new items to the build matrix for android (aarch64 and x86_64)
martindevans May 30, 2023
82f724d
Added setup for android tools
martindevans May 30, 2023
9c1ab14
Updated docs to add android targets to tier 3
martindevans May 30, 2023
87b8cdc
Removed `target add`, not necessary due to the same thing being done …
martindevans Jun 1, 2023
aed9a88
- Removed cargo check
martindevans Jun 1, 2023
d6a0e6a
prtest:full
martindevans Jun 1, 2023
6af95cc
Fixed string double quotes
martindevans Jun 1, 2023
82ac952
Swapped `aarch64-linux-android` to run on `aarch64-linux`
martindevans Jun 1, 2023
ac8d164
Attempted to prevent using fancy docker stuff for android builds
martindevans Jun 11, 2023
87bf5f7
Added NDK version to env
martindevans Jun 13, 2023
e42111e
Attempting to build with cargo-ndk
martindevans Jul 12, 2023
bd86410
running `cargo add matrix.target`
martindevans Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,6 +706,12 @@ jobs:
- build: riscv64gc-linux
os: ubuntu-latest
target: riscv64gc-unknown-linux-gnu
- build: aarch64-android
os: ubuntu-latest
target: aarch64-linux-android
- build: x86_64-android
os: ubuntu-latest
target: x86_64-linux-android
steps:
- uses: actions/checkout@v3
with:
Expand All @@ -723,6 +729,18 @@ jobs:
rustup target add ${{ matrix.target }}
if: matrix.target != ''

- run: rustup target add aarch64-linux-android
- run: rustup target add x86_64-linux-android
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these two lines can be omitted due to the step just above these

- name: Setup Android SDK
uses: android-actions/setup-android@v2
martindevans marked this conversation as resolved.
Show resolved Hide resolved
- uses: actions/cache@v3
with:
path: ${{ runner.tool_cache }}/cargo-ndk
key: cargo-ndk-bin-${{ env.CARGO_NDK_VERSION }}
- run: echo "${{ runner.tool_cache }}/cargo-ndk/bin" >> $GITHUB_PATH
- run: cargo install --root ${{ runner.tool_cache }}/cargo-ndk --version ${{ env.CARGO_NDK_VERSION }} cargo-ndk
martindevans marked this conversation as resolved.
Show resolved Hide resolved
- run: cargo ndk -t arm64-v8a -t x86_64 check -p wasmtime
martindevans marked this conversation as resolved.
Show resolved Hide resolved

# Build `wasmtime` and executables. Note that we include `all-arch` so our
# release artifacts can be used to compile `.cwasm`s for other targets.
- run: $CENTOS cargo build --release --bin wasmtime --features all-arch
Expand Down
2 changes: 2 additions & 0 deletions docs/stability-tiers.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ For explanations of what each tier means see below.
| Target | `aarch64-apple-darwin` | CI testing |
| Target | `aarch64-pc-windows-msvc` | CI testing, unwinding, full-time maintainer |
| Target | `riscv64gc-unknown-linux-gnu` | full-time maintainer |
| Target | `x86_64-linux-android` | CI testing, full-time maintainer |
| Target | `aarch64-linux-android` | CI testing, full-time maintainer |
| WASI Proposal | `wasi-nn` | More expansive CI testing |
| WASI Proposal | `wasi-crypto` | CI testing, clear owner |
| WebAssembly Proposal | `threads` | Complete implementation |
Expand Down