Correctly read from a possibly misaligned pointer #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubkon
approved these changes
Nov 22, 2019
|
I think these were the only places reported by clippy, but I'll recheck. |
Awesome, thanks a bunch! :-) |
sunfishcode
approved these changes
Nov 27, 2019
sunfishcode
added a commit
that referenced
this pull request
Dec 13, 2019
This reapplies #615, which was inadvertently reverted.
sunfishcode
added a commit
that referenced
this pull request
Dec 16, 2019
This reapplies #615, which was inadvertently reverted.
sunfishcode
added a commit
that referenced
this pull request
Dec 16, 2019
* Correctly handle possibly misaligned pointers in readdir This reapplies #615, which was inadvertently reverted. * Tidy up unneeded `self::` qualifiers. * Make Dir's contents private. Also remove the `unsafe` from `impl_iter`. With `Dir`'s field being private, we can rely on the pointer being only what we've assigned to it. * Make `poll`'s timeout argument a `libc::c_int`. This clarifies that there are no subsequent conversions before calling the underlying libc API. * Use clock_gettime instead of clock_getres to get the time. * Mark FileType::from_raw as safe. It handles unknown values, so it can be marked safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was reported in #513.
read_unalignedis definitely the most ergonomic solution but clippy still marks this as an error, see rust-lang/rust-clippy#2881 for more details.I also fixed a potentially misaligned write in the implementation of
fd_readdir.I can't ask for reviewers, so cc @kubkon @sunfishcode @peterhuene