Skip to content

Remove split_blocks_created field #6044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elliottt merged 1 commit into from
Mar 17, 2023
Merged

Remove split_blocks_created field #6044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions cranelift/frontend/src/frontend.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1095,9 +1095,6 @@ impl<'a> FunctionBuilder<'a> {
}

fn handle_ssa_side_effects(&mut self, side_effects: SideEffects) {
for split_block in side_effects.split_blocks_created {
self.func_ctx.status[split_block] = BlockStatus::Filled;
}
for modified_block in side_effects.instructions_added_to_blocks {
if self.is_pristine(modified_block) {
self.func_ctx.status[modified_block] = BlockStatus::Partial;
Expand Down
5 changes: 1 addition & 4 deletions cranelift/frontend/src/ssa.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,6 @@ pub struct SSABuilder {
/// Side effects of a `use_var` or a `seal_block` method call.
#[derive(Default)]
pub struct SideEffects {
/// When we want to append jump arguments to a `br_table` instruction, the critical edge is
/// splitted and the newly created `Block`s are signaled here.
pub split_blocks_created: Vec<Block>,
/// When a variable is used but has never been defined before (this happens in the case of
/// unreachable code), a placeholder `iconst` or `fconst` value is added to the right `Block`.
/// This field signals if it is the case and return the `Block` to which the initialization has
Expand All @@ -75,7 +72,7 @@ pub struct SideEffects {

impl SideEffects {
fn is_empty(&self) -> bool {
self.split_blocks_created.is_empty() && self.instructions_added_to_blocks.is_empty()
self.instructions_added_to_blocks.is_empty()
}
}

Expand Down