x64: Remove conditional SseOpcode::uses_src1#5842
Merged
cfallin merged 1 commit intobytecodealliance:mainfrom Feb 21, 2023
Merged
x64: Remove conditional SseOpcode::uses_src1#5842cfallin merged 1 commit intobytecodealliance:mainfrom
SseOpcode::uses_src1#5842cfallin merged 1 commit intobytecodealliance:mainfrom
Conversation
This is a follow-up to comments in bytecodealliance#5795 to remove some cruft in the x64 instruction model to ensure that the shape of an `Inst` reflects what's going to happen in regalloc and encoding. This accessor was used to handle `round*`, `pextr*`, and `pshufb` instructions. The `round*` ones had already moved to the appropriate `XmmUnary*` variant and `pshufb` was additionally moved over to that variant as well. The `pextr*` instructions got a new `Inst` variant and additionally had their constructors slightly modified to no longer require the type as input. The encoding for these instructions now automatically handles the various type-related operands through a new `SseOpcode::Pextrq` operand to represent 64-bit movements.
github-actions
bot
added
cranelift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to comments in #5795 to remove some cruft in the x64 instruction model to ensure that the shape of an
Instreflects what's going to happen in regalloc and encoding. This accessor was used to handleround*,pextr*, andpshufbinstructions. Theround*ones had already moved to the appropriateXmmUnary*variant andpshufbwas additionally moved over to that variant as well.The
pextr*instructions got a newInstvariant and additionally had their constructors slightly modified to no longer require the type as input. The encoding for these instructions now automatically handles the various type-related operands through a newSseOpcode::Pextrqoperand to represent 64-bit movements.