fuzzgen: Increase allowed stack space#5825
Draft
afonso360 wants to merge 1 commit intobytecodealliance:mainfrom
Draft
fuzzgen: Increase allowed stack space#5825afonso360 wants to merge 1 commit intobytecodealliance:mainfrom
afonso360 wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
github-actions
bot
added
the
cranelift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 Hey,
The motivation for this PR is the encoding error that @uweigand found in #5786. He had previously run fuzzgen on s390x and that sort of error should have been found. But it wasn't because we never generate large offsets in our stack accesses.
This PR allows larger stack slots that let us explore these larger offsets and hopefully more errors like this.
I've picked
8192somewhat arbitrarily, it's the next largest power of two after4096which i suspect might be the more troublesome value, although this probably depends on the ISA.With
8192we have a max stack usage per function of8 * 8192 = 65536. And with #5765 we generate at most 8 functions, so worst case8 * 8 * 8192 = 524288which still seems fairly reasonable.Opening this as a draft because it has already found issues on the AArch64 backend! (#5824)