Fix block label printing in precise-output tests#5798
Merged
elliottt merged 4 commits intobytecodealliance:mainfrom Feb 16, 2023
Merged
Fix block label printing in precise-output tests#5798elliottt merged 4 commits intobytecodealliance:mainfrom
elliottt merged 4 commits intobytecodealliance:mainfrom
Conversation
jameysharp
approved these changes
Feb 16, 2023
Contributor
jameysharp
left a comment
jameysharp
left a comment
There was a problem hiding this comment.
I have a couple of suggestions that I think make the code more clear but I believe this PR is correct as-is.
Co-authored-by: Jamey Sharp <jamey@minilop.net>
github-actions
bot
added
cranelift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a follow-up to #5780, disassemble the regions identified by
bb_starts, falling back on disassembling the whole buffer. This ensures that instructions likebr_tablethat introduce a lot of constants don't throw off capstone for the remainder of the function.