Move jump tables to the DataFlowGraph#5745
Merged
elliottt merged 1 commit intobytecodealliance:mainfrom Feb 8, 2023
Merged
Conversation
jameysharp
approved these changes
Feb 8, 2023
Contributor
jameysharp
left a comment
jameysharp
left a comment
There was a problem hiding this comment.
Seems like a sound move to me!
github-actions
bot
added
the
cranelift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the storage for jump tables off of
FunctionStenciland ontoDataFlowGraph. This change is in service of #5731, making it easier to access the jump table data in the context of helpers likeinst_values.Moving the jump table data to
DataFlowGraphis reasonable, as we are now assuming in more than one place that a jump table entry is used by at most onebr_tableinstruction. As such, it's now more instruction side-data, rather than function side-data, and makes more sense to store in theDataFlowGraph.One open question I have is whether or not we should lock down the interface to
DataFlowGraph::jump_tablesin the same way that we haveinstsandblocks. There could be some value in restricting it, but as we didn't when it was public onFunctionStencil, I left it as aPrimaryMap.