Skip to content

Fix lowering issue in x64 vany_true: sinking and using original value. #4815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cfallin merged 1 commit into from
Aug 30, 2022
Merged

Fix lowering issue in x64 vany_true: sinking and using original value. #4815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cranelift/codegen/src/isa/x64/lower.isle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3640,7 +3640,8 @@
;; Rules for `vany_true` ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

(rule (lower (vany_true val))
(with_flags (x64_ptest val val) (x64_setcc (CC.NZ))))
(let ((val Xmm val))
(with_flags (x64_ptest val val) (x64_setcc (CC.NZ)))))

;; Rules for `vall_true` ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

Expand Down
8 changes: 8 additions & 0 deletions tests/misc_testsuite/simd/issue4807.wast
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
(module
(func (result i32)
global.get 0
v128.any_true
)
(global (;0;) (mut v128) v128.const i64x2 0 0)
)