Expose new JITModule::read_got_entry function#2865
Merged
cfallin merged 1 commit intobytecodealliance:mainfrom May 4, 2021
Merged
Expose new JITModule::read_got_entry function#2865cfallin merged 1 commit intobytecodealliance:mainfrom
JITModule::read_got_entry function#2865cfallin merged 1 commit intobytecodealliance:mainfrom
Conversation
Contributor
|
Instead of exposing |
3df6087 to
e4f9eeb
Compare
JITModule::read_got_entry function
cfallin
approved these changes
May 4, 2021
Member
|
Some exciting but almost certainly unrelated CI failures on Windows -- corruption issue of some sort? (This seems to be in wiggle -- cc @pchickey @sunfishcode) restarting CI. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This hasn't been discussed in a wasmtime issue, but (together with #2786) it's needed it for bjorn3/rustc_codegen_cranelift#1166.
It exposes
a newJITModule::get_got_addressJITModule::read_got_entryfunction so that, when jitting lazily, cranelift users can inspect the GOT to determine whether a given function's entry is still their shim trampoline or not (and therefore whether the function has already been jitted). This prevents the function from being jitted differently from simultaneous requests arising from different threads.No test cases added,
because exposing a function obviously doesn't change any behaviour.Sorry, I don't know who would be an appropriate reviewer for this.