Support declaring anonymous functions and data objects#2750
Merged
cfallin merged 1 commit intobytecodealliance:mainfrom Apr 12, 2021
Merged
Support declaring anonymous functions and data objects#2750cfallin merged 1 commit intobytecodealliance:mainfrom
cfallin merged 1 commit intobytecodealliance:mainfrom
Conversation
github-actions
bot
added
cranelift
Contributor
Author
|
@pchickey Could you please review this PR? |
cfallin
reviewed
Apr 12, 2021
Member
There was a problem hiding this comment.
This looks reasonable to me overall; the API changes are relatively minor. Thanks!
It seems a little weird to rely on symbol naming to communicate to the linker to elide certain symbols from the symbol table; I guess there isn't a better out-of-band way (symbol type, etc) to ensure this happens?
Happy to merge if we're satisfied there's not a better way re: above!
Contributor
Author
|
Not that I know of. Using |
Member
|
Sounds good, then; thanks for looking into it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2220