RR #2: Sha256 checksum for components#12576
Conversation
| has_wasm_debuginfo: self.tunables.parse_wasm_debuginfo, | ||
| dwarf, | ||
| }, | ||
| checksum: WasmChecksum::from_binary(wasm), |
There was a problem hiding this comment.
Should we make this optional, only if recording is enabled? For large module compilation, one single additional pass of a digest algorithm over machine code bytes is probably not much extra overhead; but it may still be measurable in some cases and I wouldn't want to pessimize unrelated runs.
There was a problem hiding this comment.
Do you mean optional based on feature flags or optional based on the config option?
There was a problem hiding this comment.
Probably based on a dynamic check of the configuration -- eventually we'll probably have the RR feature included by default (if all goes well), but we don't necessarily want to compute a digest of everything we build.
There was a problem hiding this comment.
I guess regardless that'll require a rr feature flags on environ then. Would the checksum just be 0 when recording is disabled?
github-actions
bot
added
the
wasmtime:api
|
I've made the checksum computation optional. Since the compilation flows only have access to |
cfallin
left a comment
cfallin
left a comment
There was a problem hiding this comment.
LGTM modulo one nit below; with that fixed, and with CI green, we can merge. Thanks!
2 participants
Added checksum computations for components