Cranelift: update to regalloc2 0.12.2; support many return values. #10747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
approved these changes
May 7, 2025
Member
Author
|
In attempting to update will need to work out exactly how we handle this again... |
Prior versions of regalloc2 could not support more than 255 operands on an instruction, and together with the integrated return-value loads on call instructions introduced in bytecodealliance#10502, this caused issues with calls with many returns. This PR upgrades to a version of RA2 that supports up to `2^16 - 1` operands per instruction (well in excess of the maximum of 1000 return/result values per Wasm's implementation limits, for example). Fixes bytecodealliance#10741.
cfallin
force-pushed
the
fix-too-many-return-values
branch
from
9d87044 to
74af426
Compare
Member
|
Do you have the latest Otherwise, before this PR, if you run |
Member
Author
|
Yes, I have v0.10.1; and I actually get the same errors on |
Member
|
Looks like it needed a merge/rebase with main first |
Member
Author
|
Ah, awesome, thanks -- that's what I get for not updating my local |
cfallin
added a commit
to cfallin/wasmtime
that referenced
this pull request
May 7, 2025
…ytecodealliance#10747) * Cranelift: update to regalloc2 0.12.2; support many return values. Prior versions of regalloc2 could not support more than 255 operands on an instruction, and together with the integrated return-value loads on call instructions introduced in bytecodealliance#10502, this caused issues with calls with many returns. This PR upgrades to a version of RA2 that supports up to `2^16 - 1` operands per instruction (well in excess of the maximum of 1000 return/result values per Wasm's implementation limits, for example). Fixes bytecodealliance#10741. * Update vets --------- Co-authored-by: Alex Crichton <[email protected]>
alexcrichton
added a commit
that referenced
this pull request
May 7, 2025
…10747) (#10748) * Cranelift: update to regalloc2 0.12.2; support many return values. Prior versions of regalloc2 could not support more than 255 operands on an instruction, and together with the integrated return-value loads on call instructions introduced in #10502, this caused issues with calls with many returns. This PR upgrades to a version of RA2 that supports up to `2^16 - 1` operands per instruction (well in excess of the maximum of 1000 return/result values per Wasm's implementation limits, for example). Fixes #10741. * Update vets --------- Co-authored-by: Alex Crichton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior versions of regalloc2 could not support more than 255 operands on an instruction, and together with the integrated return-value loads on call instructions introduced in #10502, this caused issues with calls with many returns. This PR upgrades to a version of RA2 that supports up to
2^16 - 1operands per instruction (well in excess of the maximum of 1000 return/result values per Wasm's implementation limits, for example).Fixes #10741.